-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorKitSectors as a separate module #118
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…}` (#1) * Add scalartype parameter to `AbstractTensorMap` * Add scalartype in definition of TensorMap * Add scalartype to AdjointTensorMap * Add scalartype to BraidingTensor * Implement changes for indexmanipulations * Implement scalartype for linalg * implement changes for tensoroperations * implement changes for planaroperations * implement changes for ChainRules * small fixes * Fix typo * Fix missing change * Formatter * Apply scalartype changes to tests * Fix some ambiguities * De-specialize `trace_permute` * Despecialize `_contract!` * Remove unused type-parameter * Despecialize `planaradd!` and `planartrace!` * Small fixes * Change braidingtensor syntax to resolve ambiguities * despecialize some linalg methods * formatter * Add changelog entry * Fix ambiguity on Julia1.6
This changes the behaviour of copy as an instantiator for creating a TensorMap from a BraidingTensor. The rationale is that while this does sometimes happen in Julia Base, this is always in the context of lazy wrapper types, for which it makes sense to not copy the parent and then create a new wrapper. BraidingTensor does not wrap anything, so this definition makes less sense.
Incorporate changes from #aada0b2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 81.46% 0.00% -81.47%
==========================================
Files 42 36 -6
Lines 5588 4757 -831
==========================================
- Hits 4552 0 -4552
- Misses 1036 4757 +3721 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.